Use TestEnvironment::nullDevicePath instead of /dev/null/

[davinci26]

Signed-off-by: davinci26 sotirisnan@gmail.com
Changes the config file to use the cross-platform TestEnvironment::nullDevicePath() instead of /dev/null in:

1. rtds_integration_test.cc
2. cluster_integration_test.cc
3. redis_cluster_integration_test.cc
4. mysql_integration_test.cc
5. postgres_integration_test.cc
6. rtds_integration_test.cc

Additional Description:

The test list is flaky on Windows. I think it is related to #11793 and it will be less flaky when this change gets merged.

Risk Level: N/A
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

[davinci26]

@nigriMSFT @wrowe @sunjayBhatia

[dio]

@davinci26 seems like rtds_integration_test is still tagged as fails_on_windows? Probably remove that tag to test that on CI? Thank you!

[davinci26]

@dio I added why I didn't remove the tag in the pr description. The test list is still flaky. I assume my other pr will help.

[davinci26]

@sunjayBhatia do you think we could write a format rule for this one as well?

[sunjayBhatia]

@sunjayBhatia do you think we could write a format rule for this one as well?

yeah I think that is a good idea, especially as test cases get copied and pasted, if there are any /dev/nulls floating around, they will keep coming back

maybe something as simple as searching for /dev/null in a line or even more strict access_log_path: /dev/null? or maybe regex like .*: "?/dev/null"? might be worth playing around with, theres some code/examples in the format checker that applies certain checks on certain directories or not, I forget if theres format checks already on test fixture files

envoy/tools/code_format/check_format.py

Line 580 in 2a34c76

def checkSourceLine(line, file_path, reportError):

for examples and tests:

envoy/tools/code_format/check_format_test_helper.py

Line 149 in 2a34c76

def runChecks():

[davinci26]

I will fix the CI (formatting) as I add the new clang-ci rule

[wrowe]

Ping? Looking forward to this merge after the format failures are fixed.

[wrowe]

LGTM

[dio]

This one is too far?

Format check failed, try apply following patch to fix:

diff --git a/test/extensions/filters/network/redis_proxy/redis_proxy_integration_test.cc b/test/extensions/filters/network/redis_proxy/redis_proxy_integration_test.cc
index b67cab241..928758cd7 100644
--- a/test/extensions/filters/network/redis_proxy/redis_proxy_integration_test.cc
+++ b/test/extensions/filters/network/redis_proxy/redis_proxy_integration_test.cc
@@ -60,7 +60,7 @@ static_resources:
           settings:
             op_timeout: 5s
 )EOF",
-                                                        TestEnvironment::nullDevicePath());
+                                       TestEnvironment::nullDevicePath());

// This is a configuration with command stats enabled.
const std::string CONFIG_WITH_COMMAND_STATS = CONFIG + R"EOF(

[davinci26]

I am getting really confused... I am pretty sure I had it like this in the previous commit. Look at the diff here 7cedce8

[davinci26]

It took me more time that I am proud to admit but I finally got there. The CI is clean now.

Let me know if you have any other comments 😄

[dio]

Thanks