Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: introduce ResolutionStatus for ResolveCb and fix #9927 #10137

Merged
merged 15 commits into from
Feb 28, 2020
Merged

dns: introduce ResolutionStatus for ResolveCb and fix #9927 #10137

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8b16860
introduce status to the callback and maintain prior functionality
Feb 21, 2020
7f160b2
update validation resolver
Feb 21, 2020
6bc89aa
update dns impl test
Feb 22, 2020
7a90217
update upstream impl test
Feb 22, 2020
98f2205
update
Feb 25, 2020
a2385e4
missing commit
Feb 25, 2020
6cce569
update and fix #9927
Feb 26, 2020
af99ef8
release notes
Feb 26, 2020
3f9e574
Merge branch 'master' into dns-status
Feb 26, 2020
4628947
fmt
Feb 26, 2020
93b3180
update test
Feb 27, 2020
c7ee391
move line
Feb 27, 2020
a8a140e
ask and you shall receive
Feb 27, 2020
a44add4
Merge branch 'master' into dns-status
Feb 27, 2020
3d35981
circle ci
Feb 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
missing commit 
Signed-off-by: Jose Nino <jnino@lyft.com>
  • Loading branch information
Jose Nino committed Feb 25, 2020
commit a2385e4e3ae483027898ab45e36c352e8234528e
5 changes: 4 additions & 1 deletion source/common/upstream/logical_dns_cluster.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,10 @@ void LogicalDnsCluster::startResolve() {
}

std::chrono::milliseconds refresh_rate = dns_refresh_rate_ms_;
if (status == Network::DnsResolver::ResolutionStatus::Success) {
// TODO(junr03): update in subsequent PR. The logical dns cluster could update is
// current_resolved_address_ to null if the cluster receives a successful, but empty DNS
// response.
if (status == Network::DnsResolver::ResolutionStatus::Success && !response.empty()) {
// TODO(mattklein123): Move port handling into the DNS interface.
ASSERT(response.front().address_ != nullptr);
Network::Address::InstanceConstSharedPtr new_address =
Expand Down