Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wavm #32772

Closed
phlax opened this issue Mar 7, 2024 · 4 comments · Fixed by #32872
Closed

Remove wavm #32772

phlax opened this issue Mar 7, 2024 · 4 comments · Fixed by #32872

Comments

@phlax
Copy link
Member

phlax commented Mar 7, 2024

Our wavm build compiles its own llvm libs

This requires a lot of ci resources, and breaks updating llvm

We could either unbreak the llvm update or potentially just use prebuilt llvm libs, but in offline conversations it was suggested we might not need the wavm build at all as we have other wasm engines compiled with llvm

@phlax phlax added triage Issue requires triage area/wasm and removed triage Issue requires triage labels Mar 7, 2024
@phlax
Copy link
Member Author

phlax commented Mar 7, 2024

@PiotrSikora
Copy link
Contributor

SGTM, there are other LLVM-based runtimes (WAMR, WasmEdge) that are actively maintained and supported by Proxy-Wasm and Envoy.

@phlax
Copy link
Member Author

phlax commented Mar 13, 2024

i have started to do this as it will allow us to remove the additional llvm dependency that we currently pull in and compile

one thing im wondering tho is whether we need any kind of deprecation period on this or we can just remove

@phlax
Copy link
Member Author

phlax commented Mar 14, 2024

the other thing im realizing is that wamr is using the same compiler setup so removing wavm doesnt by itself resolve my initial issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants