wasm: Remove wavm
#32872
Merged
wasm: Remove wavm
#32872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
|
/retest |
phlax
commented
Mar 13, 2024
htuch
reviewed
Mar 14, 2024
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
htuch
approved these changes
Mar 18, 2024
repokitteh-read-only
bot
removed
api
deps
This was referenced Mar 19, 2024
ashishb-solo
added a commit
to solo-io/envoy-gloo
that referenced
this pull request
Apr 30, 2024
This was removed from upstream - see envoyproxy/envoy#32872
soloio-bulldozer bot
pushed a commit
to solo-io/envoy-gloo
that referenced
this pull request
May 14, 2024
* Update envoy dependency to v1.30.1 * Change repository back to upstream envoy * Remove wavm This was removed from upstream - see envoyproxy/envoy#32872 * Add some compile flags to get CEL to compile These flags are copied from upstream's .bazelrc. The most important one here is the `-fsized-deallocation` which was required to get CEL to compile. The rest may not be necessary, but since they changed in upstream from 1.29 to 1.30, I think it might be a good idea to include them. * Get matchers working There were some details in regex that were changed upstream that we had to incorporate * Fix a few flags that were moved * Get HTTP transformation to compile A few upstream Envoy functions that were being called in this library needed to be passed contexts, which required plumbing that object through the call hierarchy. Along the way, it seemed to appear that there were a few type signatures that were possibly not completely correct, and those have been adjusted to get things compiling successfully. * Fix some compile errors It seems that passing string arguments constructed with the `+` operator is not allowed in ENVOY_STREAM_LOG, and possibly other macros as well. This was my first encounter with this error, but there might be other instances lurking elsewhere in the repository. * addWatch callback must now return absl::Status * Fix type signature of createProtocolOptionsConfig The signature of this abstract class method was changed upstream - this change reflects the fix * Add changelog * Update extensions_build_config.bzl * Move changelog * Get inja_transformer_test.cc to compile Interesting lesson here - when calling `fmt::format`, we must use a constexpr, since the formatting function provides compile-time type checking. Neat! * Fix a broken test * Add router_check tool Upstream ci calls this, so we put in a dummy target here * Update bazel version * do_ci.sh debug flags * Update envoy-build-ubuntu image * Remove debug lines from do_ci.sh * Remove envoy.string_matcher.lua Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io> * Remove envoy.tracers.opentelemetry.samplers.dynatrace from bazel/extensions/extensions_build_config.bzl Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io> * Update changelog/v1.30.1-patch1/update-to-upstream-envoy-v1.30.yaml Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io> * Update source/extensions/filters/http/aws_lambda/config.cc Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io> * Revert "Update source/extensions/filters/http/aws_lambda/config.cc" This reverts commit f91e837. * Fix one more review comment * Revert `fmt::vformat` change in inja_transformer_test.cc * Add comments explaining why `//test/tools` exist * CHange auto variables to `std::string` * Change `fmt::vformat` back to `fmt::format` Previous iterations were still using the `vformat` call so they may not have been using the `constexpr` versino of formatting correctly --------- Co-authored-by: Nathan Fudenberg <nathan.fudenberg@solo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #32772
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]