build does not work from tarball, but only from git checkout

[cs224]

Title: build does not work from tarball, but only from git checkout

Description:

When downloading a release tarball, unpacking and trying to build you get the following error:

ERROR: Process exited with status 1: Process exited with status 1
fatal: Not a git repository (or any parent up to mount point /source)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
Target //source/exe:envoy-static.stamped failed to build
INFO: Elapsed time: 57.978s, Critical Path: 0.03s
FAILED: Build did NOT complete successfully

It would be nice if the build worked also on the downloadable tarballs.

Thanks,
Christian

[lavagetto]

The build process depends on the checkout being a git repository indeed - stumbled upon the same problem myself.

[mattklein123]

The main need is here: https://github.com/envoyproxy/envoy/blob/master/bazel/get_workspace_status

It should be possible to alter that script to work without git and feed in the versions, etc. from a file (or something). I'm not sure what other git needs bazel has, if any.

[merge03]

Is there a work around for this issue?

[dio]

@merge03 there are two workarounds that I can think of:

1. Create a SOURCE_VERSION file and fill it with the commit hash of the release package. e.g. for v1.6.0 release, the commit hash value will be 4dd49d8809f7aaa580538b3c228dd99a2fae92a4. This is to make the git_sha_rewriter.py happy. NOTE: Please be aware of this issue envoy --version reports old git SHA #2551 and subsequently this Replace git_sha_rewriter with Bazel native approach #2625.
2. Replace the bazel/get_workspace_status with the one in here: https://github.com/dio/envoy/blob/workaround-2181/bazel/get_workspace_status (it is "not clean" indeed, but at least it gets the commit hash from Github API, not a manual copy-pasting).

Good luck!

[merge03]

@dio Option #1 worked just fine. Just noting that the file needed to be in the ./ci directory. Didn't try #2.

Thanks for the help!

[exell-christopher]

Is there any plan to include generation of the SOURCE_VERSION file as part of the tarball generation? If someone can point me to the tooling for that I'd be happy to add it.

[yurivict]

Could you just remove git command invocation in the build?
git is a tool to manage sources and for collaboration, it is not to be called from inside of the build.

All version information should be provided from outside through command arguments.