Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated http_match_on_all_headers and http_set_copy_replace_all_headers #16018

Closed
alyssawilk opened this issue Apr 15, 2021 · 2 comments · Fixed by #16209
Closed

deprecated http_match_on_all_headers and http_set_copy_replace_all_headers #16018

alyssawilk opened this issue Apr 15, 2021 · 2 comments · Fixed by #16209
Assignees
@alyssawilk
Labels
tech debt

Comments

@alyssawilk
Copy link
Contributor 

"envoy.reloadable_features.http_match_on_all_headers",
"envoy.reloadable_features.http_set_copy_replace_all_headers",

The script didn't work for these two since they merged with issue #195 which doesn't make any sense.

assigning to myself to dig up their origin
@alyssawilk alyssawilk self-assigned this Apr 15, 2021
@mattklein123
Copy link
Member

@alyssawilk I think it refers to setec issue 195 :(

@alyssawilk
Copy link
Contributor Author

haha, I'd checked setec PR 195, and it wasn't that.

@alyssawilk alyssawilk mentioned this issue Apr 27, 2021
Merged
alyssawilk added a commit that referenced this issue Apr 28, 2021
@alyssawilk
http: removing envoy.reloadable_features.http_match_on_all_headers (#…
152762a 
…16195)

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Part of #16018

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk alyssawilk mentioned this issue Apr 28, 2021
Merged
alyssawilk added a commit that referenced this issue Apr 28, 2021
@alyssawilk
http: removing envoy.reloadable_features.http_set_copy_replace_all_he…
aa3d8a1 
…aders (#16209)

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes #16018

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
gokulnair pushed a commit to gokulnair/envoy that referenced this issue May 6, 2021
@alyssawilk
http: removing envoy.reloadable_features.http_match_on_all_headers (e…
61b464a 
…nvoyproxy#16195)

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Part of envoyproxy#16018

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Gokul Nair <gnair@twitter.com>
gokulnair pushed a commit to gokulnair/envoy that referenced this issue May 6, 2021
@alyssawilk
http: removing envoy.reloadable_features.http_set_copy_replace_all_he…
fb2178e 
…aders (envoyproxy#16209)

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Fixes envoyproxy#16018

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Gokul Nair <gnair@twitter.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssawilk alyssawilk

Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

http: removing envoy.reloadable_features.http_set_copy_replace_all_heders alyssawilk/envoy
2 participants
@mattklein123 @alyssawilk