-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: better build @com_googlesource_chromium_v8:build #15145
Comments
The official Bazel support has been requested from the V8 team (https://bugs.chromium.org/p/v8/issues/detail?id=11234), and I don't think we can do too much until that's ready, since Envoy doesn't want to maintain custom To address the issue at hand, perhaps we could provide an upper bound to limit the number of CPUs that |
Thank you for the confirmation and for sharing the update at chromium! I don't think Envoy should invest too much. |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
V8 team is working on this right now, and V8 v9.3 (branch cut on 7/15) should have native Bazel support. |
Fixes #15145. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Fixes envoyproxy#15145. Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Josh Perry <josh.perry@mx.com>
Fixes envoyproxy#15145. Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Fixes #15145. Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
This target is internal spawn lots of tasks within. However, this target is considered as a single-core task from the view of bazel scheduler.
Generally speaking, when you run
bazel build //source/exe:envoy
with N cores, N tasks will be scheduled and at most N clang is running. However, if the running task contains @com_googlesource_chromium_v8:build, ~2N clang is running, and the peak ram usage could be huge.A workaround: you may want to run
bazel build @com_googlesource_chromium_v8//:build
first, exhausting the cpu and ram.When the above task is completed, you can run
bazel build YOUR_REAL_TARGET
using the build cache of the above v8 build.The text was updated successfully, but these errors were encountered: