Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extensions/filters/http/aws_request_signing coverage #11990

Closed
alyssawilk opened this issue Jul 9, 2020 · 1 comment · Fixed by #12229
Closed

extensions/filters/http/aws_request_signing coverage #11990

alyssawilk opened this issue Jul 9, 2020 · 1 comment · Fixed by #12229
Assignees
@marcomagdy @rgs1 @derekargueta
Labels
no stalebot Disables stalebot from closing an issue tech debt

Comments

@alyssawilk
Copy link
Contributor

Hello,
The Envoy project has recently started collecting per-extension coverage. You have been tagged with this issue as you are a co-owner of an extension, extensions/filters/http/aws_request_signing, which is below the 96.6 percent coverage mark.
Could you please take a look at coverage results (https://storage.googleapis.com/envoy-postsubmit/master/coverage/index.html) and add more tests when you get a chance? Once this is done you should be able to remove your extension from the exempt extensions in test/per_file_coverage.sh
Thanks!
@alyssawilk alyssawilk added no stalebot Disables stalebot from closing an issue tech debt labels Jul 9, 2020
rgs1 pushed a commit to rgs1/envoy that referenced this issue Jul 22, 2020
aws_request_signing: fix coverage
cc948f9 
Fixes envoyproxy#11990.

Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
@rgs1 rgs1 mentioned this issue Jul 22, 2020
Merged
@rgs1
Copy link
Member

rgs1 commented Jul 22, 2020

#12229 should do it.

zuercher pushed a commit that referenced this issue Jul 22, 2020
aws_request_signing: fix coverage (#12229)
31cb2b4 
Fixes #11990.

Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
KBaichoo pushed a commit to KBaichoo/envoy that referenced this issue Jul 30, 2020
@KBaichoo
aws_request_signing: fix coverage (envoyproxy#12229)
5ce5e07 
Fixes envoyproxy#11990.

Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
chaoqin-li1123 pushed a commit to chaoqin-li1123/envoy that referenced this issue Aug 7, 2020
aws_request_signing: fix coverage (envoyproxy#12229)
2543df7 
Fixes envoyproxy#11990.

Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcomagdy marcomagdy

@rgs1 rgs1

@derekargueta derekargueta

Labels
no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

aws_request_signing: fix coverage rgs1/envoy
4 participants
@marcomagdy @rgs1 @derekargueta @alyssawilk