Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extensions/filters/http/aws_lambda coverage #11989

Closed
alyssawilk opened this issue Jul 9, 2020 · 1 comment · Fixed by #12368
Closed

extensions/filters/http/aws_lambda coverage #11989

alyssawilk opened this issue Jul 9, 2020 · 1 comment · Fixed by #12368
Assignees
@marcomagdy @lavignes
Labels
no stalebot Disables stalebot from closing an issue tech debt

Comments

@alyssawilk
Copy link
Contributor

Hello,
The Envoy project has recently started collecting per-extension coverage. You have been tagged with this issue as you are a co-owner of an extension, extensions/filters/http/aws_lambda, which is below the 96.6 percent coverage mark.
Could you please take a look at coverage results (https://storage.googleapis.com/envoy-postsubmit/master/coverage/index.html) and add more tests when you get a chance? Once this is done you should be able to remove your extension from the exempt extensions in test/per_file_coverage.sh
Thanks!
@alyssawilk alyssawilk added no stalebot Disables stalebot from closing an issue tech debt labels Jul 9, 2020
@landesherr landesherr mentioned this issue Jul 29, 2020
Merged
alyssawilk pushed a commit that referenced this issue Jul 30, 2020
@landesherr
aws_lambda: Increase code coverage in AWS Lambda filter (#12368)
11669e4 
Commit Message: Increase code coverage in AWS Lambda filter
Additional Description: Removing unreachable/dead lines of code, remove aws_lambda from per_file_coverage.sh
Risk Level: Low
Testing: bazel test //test/extensions/filters/http/aws_lambda/...
Docs Changes: N/A
Release Notes: N/A
Fixes #11989

Signed-off-by: Nolan Varani <landesherr@users.noreply.github.com>
@lavignes
Copy link
Member

thanks @landesherr

@landesherr landesherr mentioned this issue Jul 30, 2020
Closed
chaoqin-li1123 pushed a commit to chaoqin-li1123/envoy that referenced this issue Aug 7, 2020
@landesherr
aws_lambda: Increase code coverage in AWS Lambda filter (envoyproxy#1…
aa70cbb 
…2368)

Commit Message: Increase code coverage in AWS Lambda filter
Additional Description: Removing unreachable/dead lines of code, remove aws_lambda from per_file_coverage.sh
Risk Level: Low
Testing: bazel test //test/extensions/filters/http/aws_lambda/...
Docs Changes: N/A
Release Notes: N/A
Fixes envoyproxy#11989

Signed-off-by: Nolan Varani <landesherr@users.noreply.github.com>
chaoqin-li1123 pushed a commit to chaoqin-li1123/envoy that referenced this issue Aug 7, 2020
@landesherr
aws_lambda: Increase code coverage in AWS Lambda filter (envoyproxy#1…
a8e10e7 
…2368)

Commit Message: Increase code coverage in AWS Lambda filter
Additional Description: Removing unreachable/dead lines of code, remove aws_lambda from per_file_coverage.sh
Risk Level: Low
Testing: bazel test //test/extensions/filters/http/aws_lambda/...
Docs Changes: N/A
Release Notes: N/A
Fixes envoyproxy#11989

Signed-off-by: Nolan Varani <landesherr@users.noreply.github.com>
Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcomagdy marcomagdy

@lavignes lavignes

Labels
no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

aws_lambda: Increase code coverage in AWS Lambda filter landesherr/envoy
3 participants
@marcomagdy @lavignes @alyssawilk