Splitting out custom header parsers into a utils file

[aunu53]

The documentation and process around custom header processing is a little confusing, specifically in how exactly things are queried into streaminfo. I'd like to move the three StreamInfo -> String parse* functions from header_formatter.cc functions into a separate file, maybe HeaderFormatterUtils. This way, I can import the parsers into my filter tests and verify my filter changes StreamInfo correctly. Would this be ok?

[mattklein123]

cc @qiwzhang who was just looking at this during the local reply work. Please sync up with him. In general, anything we can do to improve code reuse and clarity here would be great. We have a lot of overlap with header parsers, access log parsers, etc.

[aunu53]

@qiwzhang I looked through your recent PRs and they don't seem directly related to this. Are you ok with the proposed change?

[qiwzhang]

In this #11007, I was asked to move access_log_formatter code out of access_log folder since it is not only used by access_log, but also local_reply. Your request is in the same direction. I have not started the work yet.

You can expand this issue to re-factory access_log_formatter out of access_log folder together with your requirement of making unit-test of these specific functions easier. Do you want to take that work?

[qiwzhang]

@mattklein123 , @auni53 Sorry, your HeaderFormatter is at router folder, it is totally different with the one in access_log folder. So my task of access_log_formatter refractory is irrelevant with your issue here.

[qiwzhang]

My pr to refractory access_log_formatter is #11330

[stale]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.