Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert v2 API test fragments to v3 #10843

Closed
htuch opened this issue Apr 20, 2020 · 14 comments · Fixed by #11213, #11894, #11973, #12072 or #12113
Closed

Convert v2 API test fragments to v3 #10843

htuch opened this issue Apr 20, 2020 · 14 comments · Fixed by #11213, #11894, #11973, #12072 or #12113
Assignees
@ankatare
Labels
api/v3 Major version release @ end of Q3 2019 beginner Good starter issues! no stalebot Disables stalebot from closing an issue tech debt

Comments

@htuch
Copy link
Member

htuch commented Apr 20, 2020

While all programatically constructed test configs will be v3 (via API boosting rewriting), there are still v2 JSON/YAML fragments in test code. Many of these will "just work" as v3, but some may have v2 features that will have them treated as v2. This becomes confusing when they are extended by developers who want to model v3 features.

These need to be audited and updated as appropriate. Also, the names of methods such as parseAccessLogFromV2Yaml should be updated to reflect v3 when operating on fragments that should be v3.

This is somewhat similar to the work done by @dmitri-d for examples in #10644 as part of #9735.

CC @alyssawilk
@htuch htuch added api/v3 Major version release @ end of Q3 2019 beginner Good starter issues! help wanted Needs help! tech debt labels Apr 20, 2020
@ankatare
Copy link
Contributor

@htuch i would like to work on this as part of beginner in community.

@htuch
Copy link
Member Author

htuch commented Apr 20, 2020

@ankatare sure, I sent you an invite to the envoyproxy org so I can assign. I suggest following #10644, since that already provides a lot of the heavy lifting in terms of examples of what needs to be done.

@ankatare
Copy link
Contributor

@htuch thanks for adding me in member list. as you suggested let me go through #10644 . I will get back for any doubts.

@htuch htuch removed the help wanted Needs help! label Apr 21, 2020
@ankatare
Copy link
Contributor

@htuch i read #10644 and found that changes were made in docs/root directory from V2 API ref to V3 API wherever applicable . from the problem statement for this issue do i need to make similar changes (in json and ymal) inside directory structure ../test/ , please correct if i am wrong.
This has to be done in current development branch ?

@htuch
Copy link
Member Author

htuch commented Apr 27, 2020

@ankatare yep, that's the goal.

@ankatare ankatare mentioned this issue May 1, 2020
Merged
This was referenced May 15, 2020
Merged
Closed
@stale
Copy link

stale bot commented May 30, 2020

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label May 30, 2020
@ankatare
Copy link
Contributor

/no stalest

@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label May 30, 2020
@alyssawilk alyssawilk added help wanted Needs help! no stalebot Disables stalebot from closing an issue and removed help wanted Needs help! labels Jun 1, 2020
junr03 pushed a commit that referenced this issue Jun 26, 2020
@ankatare
Convert cluster-related v2 API test fragments to v3 (#11031)
19f5803 
Commit Message: changes in test files for "Convert v2 API test fragments to v3"
Additional Description: file changes in test/common/upstream/
Testing: format test and integration test
Progress toward #10843

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@ankatare ankatare mentioned this issue Jul 6, 2020
Merged
htuch pushed a commit that referenced this issue Jul 6, 2020
@ankatare
V2 to v3 fragment (#11213)
e73738f 
Risk Level:Low
Testing: integration and format testing

Part of #10843

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@htuch
Copy link
Member Author

htuch commented Jul 6, 2020

This shouldn't be closed.

@htuch htuch reopened this Jul 6, 2020
@ankatare ankatare mentioned this issue Jul 7, 2020
Closed
@ankatare
Copy link
Contributor

@alyssawilk thanks for this suggestion i will tc it from next time.

@ankatare ankatare mentioned this issue Jul 15, 2020
Merged
@ankatare
Copy link
Contributor

@alyssawilk would you check this PR#12113. hope now it is fine as per your suggestion ?

htuch pushed a commit that referenced this issue Jul 16, 2020
@ankatare
V2 v3 changes for parse foo from v2 json (#12113)
9af3796 
V2 to V3 changes for parseFoofromV2json
:
Risk Level: NA
Testing: unit and format
Docs Changes: NA

Part of #10843

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@htuch htuch reopened this Jul 16, 2020
@htuch
Copy link
Member Author

htuch commented Jul 16, 2020

What's super weird is that I manually modify the commit messages and switch them from "Fixes #123456" to "Part of #123456" when I merge. GitHub still seems to close them out.

junr03 pushed a commit that referenced this issue Jul 18, 2020
@ankatare
changes for http and access_log folders (#12027)
847eafe 
Commit Message: changes for http and access_log folders
Risk Level:NA
Testing: Unit and format testing
Docs Changes: NA
part of #10843

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@ankatare
Copy link
Contributor

@junr03 Hi, would you please review PR #12058 . it will close this issue if all goes good :)

KBaichoo pushed a commit to KBaichoo/envoy that referenced this issue Jul 30, 2020
@ankatare @KBaichoo
V2 v3 fragment change for router directory (envoyproxy#11973)
e71a34e 
V2 to V3 changes related to test/commom/router/ directory.

Risk Level: Low
Testing: unit, integration and format testing
Docs Changes: NA

Relates to envoyproxy#10843

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
KBaichoo pushed a commit to KBaichoo/envoy that referenced this issue Jul 30, 2020
@ankatare @KBaichoo
V2 v3 changes for parse foo from v2 json (envoyproxy#12113)
4f99d16 
V2 to V3 changes for parseFoofromV2json
:
Risk Level: NA
Testing: unit and format
Docs Changes: NA

Part of envoyproxy#10843

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
KBaichoo pushed a commit to KBaichoo/envoy that referenced this issue Jul 30, 2020
@ankatare @KBaichoo
changes for http and access_log folders (envoyproxy#12027)
e9bbdc5 
Commit Message: changes for http and access_log folders
Risk Level:NA
Testing: Unit and format testing
Docs Changes: NA
part of envoyproxy#10843

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
junr03 pushed a commit that referenced this issue Jul 31, 2020
@ankatare
V2 TO V3 fragment changes for extension and server directory under te…
ae0c311 
…st/.. (#12058)

Commit Message: v2 to v3 fragment changes for extension and server directory test cases.
Risk Level: Low
Testing: unit and format
Fixes #10843

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
scheler pushed a commit to scheler/envoy that referenced this issue Aug 4, 2020
@ankatare
V2 to v3 fragment (envoyproxy#11213)
115deb4 
Risk Level:Low
Testing: integration and format testing

Part of envoyproxy#10843

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Signed-off-by: scheler <santosh.cheler@appdynamics.com>
scheler pushed a commit to scheler/envoy that referenced this issue Aug 4, 2020
@ankatare
v2 to v3 fragment changes for parseClusterFromV2Yaml (envoyproxy#11894)
ab82fc2 
v2 to v3 fragment changes for parseClusterFromV2Yaml

Risk Level: low
Testing: unit, format and integration test
Docs Changes: NA
Release Notes:
Part of envoyproxy#10843

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Signed-off-by: scheler <santosh.cheler@appdynamics.com>
scheler pushed a commit to scheler/envoy that referenced this issue Aug 4, 2020
@ankatare
v2 to v3 changes for function constructConfigFromV2Yaml (envoyproxy#1…
e1adb51 
…2072)

v2 to v3 changes for function constructConfigFromV2Yaml under file "test/common/tcp_proxy/tcp_proxy_test.cc"
Additional Description: This PR is duplicate of PR envoyproxy#11923

Part of envoyproxy#10843 

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Signed-off-by: scheler <santosh.cheler@appdynamics.com>
scheler pushed a commit to scheler/envoy that referenced this issue Aug 4, 2020
@ankatare
V2 v3 fragment change for router directory (envoyproxy#11973)
2d609eb 
V2 to V3 changes related to test/commom/router/ directory.

Risk Level: Low
Testing: unit, integration and format testing
Docs Changes: NA

Relates to envoyproxy#10843 

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Signed-off-by: scheler <santosh.cheler@appdynamics.com>
scheler pushed a commit to scheler/envoy that referenced this issue Aug 4, 2020
@ankatare
V2 v3 changes for parse foo from v2 json (envoyproxy#12113)
fcc8270 
V2 to V3 changes for parseFoofromV2json
:
Risk Level: NA
Testing: unit and format
Docs Changes: NA

Part of envoyproxy#10843

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Signed-off-by: scheler <santosh.cheler@appdynamics.com>
scheler pushed a commit to scheler/envoy that referenced this issue Aug 4, 2020
@ankatare
changes for http and access_log folders (envoyproxy#12027)
6d295e5 
Commit Message: changes for http and access_log folders
Risk Level:NA
Testing: Unit and format testing
Docs Changes: NA
part of envoyproxy#10843

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Signed-off-by: scheler <santosh.cheler@appdynamics.com>
chaoqin-li1123 pushed a commit to chaoqin-li1123/envoy that referenced this issue Aug 7, 2020
@ankatare
V2 TO V3 fragment changes for extension and server directory under te…
eda6652 
…st/.. (envoyproxy#12058)

Commit Message: v2 to v3 fragment changes for extension and server directory test cases.
Risk Level: Low
Testing: unit and format
Fixes envoyproxy#10843

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
chaoqin-li1123 pushed a commit to chaoqin-li1123/envoy that referenced this issue Aug 7, 2020
@ankatare
V2 TO V3 fragment changes for extension and server directory under te…
1548eb0 
…st/.. (envoyproxy#12058)

Commit Message: v2 to v3 fragment changes for extension and server directory test cases.
Risk Level: Low
Testing: unit and format
Fixes envoyproxy#10843

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankatare ankatare

Labels
api/v3 Major version release @ end of Q3 2019 beginner Good starter issues! no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
3 participants
@ankatare @htuch @alyssawilk