Add TODO for C++20

Signed-off-by: Alex Konradi <akonradi@google.com>
envoyproxy · Nov 23, 2020 · 72d8755 · 72d8755
1 parent 4c457c3
commit 72d8755
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/source/common/common/interval_value.h b/source/common/common/interval_value.h
@@ -26,6 +26,12 @@ template <typename T, typename Interval> class ClosedIntervalValue {
   T value_;
 };
 
+// C++17 doesn't allow templating on floating point values, otherwise that's
+// what we should do here instead of relying on a int => float implicit
+// conversion. TODO(akonradi): when Envoy is using C++20, switch these template
+// parameters to floats.
+
+// Floating point value in the range [0, 1].
 using UnitFloat = ClosedIntervalValue<float, Interval<int, 0, 1>>;
 
 } // namespace Envoy