Skip to content

Commit

Permalink
bazel: disable lld on macOS (#18922)
Browse files Browse the repository at this point in the history
I'm not sure what changed here but it seems chromium attempts to use lld
on macOS even though it doesn't ship with Xcode. This could be
intentional on their part if they require folks to use an llvm toolchain
instead, but this likely isn't the right move for envoy unless we vendor
that toolchain ourselves. For now we can safely disable this.

#16482 (comment)

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
  • Loading branch information
keith authored Nov 7, 2021
1 parent 0264041 commit 2ce5325
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions bazel/external/wee8.genrule_cmd
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,11 @@ WEE8_BUILD_ARGS+=" v8_use_external_startup_data=false"
# TODO(PiotrSikora): remove when fixed upstream.
WEE8_BUILD_ARGS+=" v8_enable_shared_ro_heap=false"

# Disable lld on Darwin since it's not vendored with Xcode
if [[ $${SYSTEM} == Darwin ]]; then
WEE8_BUILD_ARGS+=" use_lld=false"
fi

# Set target architecture.
if [[ $${ARCH} == "x86_64" ]]; then
WEE8_BUILD_ARGS+=" target_cpu=\"x64\""
Expand Down

0 comments on commit 2ce5325

Please sign in to comment.