Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: Add androidndk fetching workaround #2039

Closed
wants to merge 1 commit into from

Conversation

keith
Copy link
Member

@keith keith commented Feb 4, 2022

bazel/android_configure.bzl Outdated Show resolved Hide resolved
jpsim
jpsim previously approved these changes Feb 4, 2022
Copy link
Contributor

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic. Thanks.

jpsim
jpsim previously approved these changes Feb 4, 2022
This works around bazelbuild/bazel#14260

This is based on tensorflow's implementation https://github.com/tensorflow/tensorflow/tree/34c03ed67692eb76cb3399cebca50ea8bcde064c/third_party/android

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
@keith keith force-pushed the ks/bazel-add-androidndk-fetching-workaround branch from ef5eeaa to eef0c83 Compare February 4, 2022 17:23
@keith keith marked this pull request as ready for review February 4, 2022 17:24
@keith
Copy link
Member Author

keith commented Feb 4, 2022

landed in c175c77

@keith keith closed this Feb 4, 2022
@keith keith deleted the ks/bazel-add-androidndk-fetching-workaround branch February 4, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants