Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swift: enforce style guide via SwiftLint #26

Closed
rebello95 opened this issue Jun 3, 2019 · 1 comment · Fixed by #62
Closed

swift: enforce style guide via SwiftLint #26

rebello95 opened this issue Jun 3, 2019 · 1 comment · Fixed by #62
Assignees
@keith @rebello95
Labels
no stalebot platform/ios Issues related to iOS
Milestone
v0.1 "Antipasto"

Comments

@rebello95
Copy link
Contributor

Integrate SwiftLint on CI for Swift styling.

We all agree that our style guide should be encoded in linters, not up to reviewers eyes. CI should catch errors in a "check_format" run.
@rebello95 rebello95 added no stalebot platform/ios Issues related to iOS labels Jun 3, 2019
@rebello95 rebello95 changed the title ios: enforce style guide via SwiftLint swift: enforce style guide via SwiftLint Jun 3, 2019
@mattklein123 mattklein123 added this to the v0.1 "Antipasto" milestone Jun 7, 2019
@rebello95 rebello95 mentioned this issue Jun 10, 2019
Merged
@rebello95
Copy link
Contributor Author

#62

rebello95 added a commit that referenced this issue Jun 10, 2019
@rebello95
ci: run SwiftLint on CI (#62)
c91f93d 
Resolves #26

Signed-off-by: Michael Rebello <mrebello@lyft.com>
@junr03 junr03 mentioned this issue Jul 3, 2019
Closed
@Augustyniak Augustyniak mentioned this issue Nov 2, 2022
Closed
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 28, 2022
@rebello95 @jpsim
ci: run SwiftLint on CI (#62)
b46685e 
Resolves envoyproxy/envoy-mobile#26

Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 29, 2022
@rebello95 @jpsim
ci: run SwiftLint on CI (#62)
1aaa76e 
Resolves envoyproxy/envoy-mobile#26

Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keith keith

@rebello95 rebello95

Labels
no stalebot platform/ios Issues related to iOS
Projects
None yet
Milestone
v0.1 "Antipasto"
Development

Successfully merging a pull request may close this issue.

ci: run SwiftLint on CI envoyproxy/envoy-mobile
3 participants
@keith @rebello95 @mattklein123