Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set USE_CLANG_CL=1 to force substitute llvm tools #88

Merged
merged 7 commits into from
Aug 21, 2020
Merged

Set USE_CLANG_CL=1 to force substitute llvm tools #88

merged 7 commits into from
Aug 21, 2020

Commits on Jul 24, 2020

  1. Set USE_CLANG_CL=1 to force substitute llvm tools

    It seems bazel-toolchains does not as of yet let us choose the actual
    compiler we are targeting so the cc-compiler-x64_windows always points
    to msvc-cl while on Linux, cc-compiler-k8 points to the correct compiler
    (gcc or clang etc.).
    
    With this change, we are in fact still using the compiler named msvc-cl
    but the toolchain config points to llvm tools rather than MSVC tools.
    The MSVC cl.exe and link.exe command syntax is what is common.
    
    We may be able to undo this if either Bazel itself is able to change its
    CC toolchain rules for Windows to match the better Linux pattern (and do
    away with the USE_CLANG_CL logic) or bazel-toolchains has a good way of
    specifying a target cpu and compiler (so we can for example specify
    x64_windows and clang-cl or x64_windows and msvc-cl to get the correct
    toolchain).
    
    Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
    Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
    Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com>
    Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
    wrowe and sunjayBhatia committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    83f611a View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2020

  1. Merge remote-tracking branch 'origin/master' into clang-cl-add-env-var

    Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com>
    Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
    wrowe and sunjayBhatia committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    a90e7d9 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. Configuration menu
    Copy the full SHA
    540d799 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. Configuration menu
    Copy the full SHA
    aff02b9 View commit details
    Browse the repository at this point in the history
  2. No change, tickle CI to work around unexpected failure

    Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com>
    Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
    Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
    wrowe and sunjayBhatia committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    b7399d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2020

  1. Bump bazel-toolchains to pick up fix

    Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
    Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
    sunjayBhatia and wrowe committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    57d909e View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. Configuration menu
    Copy the full SHA
    bbfbc8c View commit details
    Browse the repository at this point in the history