Add llvm 10 and nasm to Windows build image #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
start base of clang-cl toolchain config, may need to add additional environment variables in the future Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: William A Rowe Jr <wrowe@vmware.com> Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
|
cc @htuch we're starting to add clang-cl support to our build environment/toolchains so we can demonstrate the work to be done in envoy and external dependencies |
lizan
approved these changes
Jul 24, 2020
htuch
pushed a commit
that referenced
this pull request
Jul 24, 2020
[skip ci] Add llvm 10 and nasm (#86) start base of clang-cl toolchain config, may need to add additional environment variables in the future Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also starts the base of the clang-cl toolchain config, may need to add additional environment variables in the future to ensure the clang-cl toolchain config uses the correct compilation tools