Update bazel-toolchains #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
force-pushed
the
ks/update-bazel-toolchains
branch
from
fc99702
to
23fb91a
Compare
This was referenced Aug 19, 2022
Closed
|
@lizan can you give me some tips on debugging the windows side of things? i haven't dove in but i assume you might know what's going wrong off the top of your head |
|
I have no idea on Windows, @wrowe? |
keith
added a commit
to keith/envoy
that referenced
this pull request
Aug 23, 2022
This depends on envoyproxy/envoy-build-tools#181 which currently requires some unknown fixes for windows. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
keith
added a commit
to envoyproxy/envoy
that referenced
this pull request
Aug 24, 2022
This depends on envoyproxy/envoy-build-tools#181 which currently requires some unknown fixes for windows. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
envoyproxy/envoy#22758 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
keith
force-pushed
the
ks/update-bazel-toolchains
branch
from
bb67802
to
265fc63
Compare
lizan
approved these changes
Aug 26, 2022
htuch
pushed a commit
that referenced
this pull request
Aug 26, 2022
[skip ci] Update bazel-toolchains (#181)
oschaaf
pushed a commit
to maistra/envoy
that referenced
this pull request
Oct 26, 2022
This depends on envoyproxy/envoy-build-tools#181 which currently requires some unknown fixes for windows. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
envoyproxy/envoy#22758
Signed-off-by: Keith Smiley keithbsmiley@gmail.com