Bump dependencies in Windows build container #113
Conversation
LLVM 11 bump may require Bazel 4.0.0 to avoid erronious LIB and INCLUDE path construction, testing whether 3.7.0 can build this toolchain itself, adjusting rules_cc specific to envoy in envoyproxy/envoy#13688 If this fails, we will need to wait till 2nd week December for Bazel 4.0.0 release. Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Signed-off-by: William A Rowe Jr <wrowe@vmware.com> Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
The anticipated flavors for envoy to build for clang-cl are 3.7.1/4.0.0, these obviously do not exist, yet. Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
|
FYI @envoyproxy/windows-dev folks, several significant bumps coming up, including MSVC toolchain to current |
| https://github.com/llvm/llvm-project/releases/download/llvmorg-10.0.0/LLVM-10.0.0-win64.exe ` | ||
| 893f8a12506f8ad29ca464d868fb432fdadd782786a10655b86575fc7fc1a562 | ||
| https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/LLVM-11.0.0-win64.exe ` | ||
| a773ee3519ecc8d68d91f0ec72ee939cbed8ded483ba8e10899dc19bccba1e22 |
There was a problem hiding this comment.
This will break clang-cl out of the box for developers. We haven't made any announcement of this, and llvm 10.0.0 had it's own list of optimization defects that didn't let us build a number of tests on Windows.
My suggestion is to ignore this breakage, it will be self-healing when the envoy WORKSPACE is updated to either bazel 3.7.1 or 4.0.0.
There was a problem hiding this comment.
Do you want to pull the LLVM and Bazel version changes out into a separate draft PR? We can bump the other deps standalone in this PR and get them working in the build quicker
There was a problem hiding this comment.
If this "works", I would rather have llvm 11.0.0 live. Bumping the WORKSPACE to bazel 4.0.0 will cause this to "just work" - I expected we would give this specific docker image a full spin, using the test build of bazel with the rules_cc bump.
There was a problem hiding this comment.
In any case, regenerating the toolchains now would be nice for testing bazel 3.7.0 ahead of the 4.0.0 build (across the board.)
There was a problem hiding this comment.
I think we saw that even the MSVC toolchain doesn't work given a Bazel version without our fix so this is unmergable as-is (the CI check to regenerate toolchains passes in this PR b/c of this line), the CI check for post-merge and generate toolchains will fail
There was a problem hiding this comment.
I'm going to correct myself. We should leave the bazel change to 3.6.0+3.7.0 in place. We need to back off the llvm change until bazel 3.7.1/4.0.0. I'll adjust this now.
Even invoking bazel to build msvc-cl, building against llvm 11.0.0 still fails (this was @davinci26's earlier observation), see
envoyproxy/envoy#13688 (comment)
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
| # python installer needs to be run as an installer with Start-Process | ||
| RunAndCheckError "$env:TEMP\python3-installer.exe" @("/quiet", "InstallAllUsers=1", "Include_launcher=0", "InstallLauncherAllUsers=0") $true | ||
| AddToPath $env:ProgramFiles\Python38 | ||
| AddToPath $env:ProgramFiles\Python38\Scripts | ||
| AddToPath $env:ProgramFiles\Python39 |
There was a problem hiding this comment.
It would be nice to automate this at some point down the road.
|
@wrowe I think this is good to go, maybe just update the PR description? |
|
cc @lizan before we merge since this includes a Bazel version bump in the generated toolchains |
|
/wait we might get a bazel 3.7.1 very soon and can bump to 3.7.1 instead of 3.7.0, see bazelbuild/bazel#12188 (comment) |
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
|
@lizan before you merge we've got a couple changes coming, we want to wait until Bazel 3.7.1 is out and some dockerfile changes |
|
@sunjayBhatia sure, or we can just merge this and do them as follow up. Then we can do some test in envoy, up to you. |
|
@lizan actually, cool to merge as is |
[skip ci] Bump dependencies in Windows build container (#113) LLVM 11 bump may require Bazel 4.0.0 to avoid erronious LIB and INCLUDE path construction, testing whether 3.7.0 can build this toolchain itself, adjusting rules_cc specific to envoy in envoyproxy/envoy#13688 If this fails, we will need to wait till 2nd week December for Bazel 4.0.0 release. Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
[skip ci] Regenerate linux toolchains from b19d749 [skip ci] Bump dependencies in Windows build container (#113) LLVM 11 bump may require Bazel 4.0.0 to avoid erronious LIB and INCLUDE path construction, testing whether 3.7.0 can build this toolchain itself, adjusting rules_cc specific to envoy in envoyproxy/envoy#13688 If this fails, we will need to wait till 2nd week December for Bazel 4.0.0 release. Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
Bump Bazel versions to 3.6.0 and 3.7.0 and bump various Windows dependencies
Exclude bumping to LLVM 11 for now:
Release 3.7 - October 2020 bazelbuild/bazel#12188 (comment) for discussion.)