Skip to content

Add api_go_proto_library targets for HTTP connection manager protos.#584

Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
jmillikin-stripe:http-config-go-targets
Mar 27, 2018
Merged

Add api_go_proto_library targets for HTTP connection manager protos.#584
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
jmillikin-stripe:http-config-go-targets

Conversation

@jmillikin-stripe
Copy link
Contributor

These are required to generate xDS responses from a Go binary. If they
don't exist, implementations are required to vendor the data-plane-api
with this change applied.

Signed-off-by: John Millikin jmillikin@stripe.com

cc @kshia

These are required to generate xDS responses from a Go binary. If they
don't exist, implementations are required to vendor the data-plane-api
with this change applied.

Signed-off-by: John Millikin <jmillikin@stripe.com>
@mattklein123
Copy link
Member

@jmillikin-stripe seems fine. Can you fix tests?

Signed-off-by: John Millikin <jmillikin@stripe.com>
@jmillikin-stripe
Copy link
Contributor Author

OK, tests are green.

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyessenov @htuch this keeps coming up but how can we verify this during CI? Is there any way to do it?

@kyessenov
Copy link
Contributor

Perhaps, there is a way to add go_library into api macro? I haven't followed the progress on bazel front lately (once istio dropped bazel). I know it is extra difficult with gogo protobuf, so it is not worth using bazel for go-control-plane builds.

@jmillikin-stripe
Copy link
Contributor Author

Why are we using these "api macros" instead of proto_library and go_proto_library?

@kyessenov
Copy link
Contributor

proto_library needs to be weaved through cc rules which did not support native proto_library when this was written. The purpose of the api_macro was to get all three languages at once (cc, py, go).

@mattklein123
Copy link
Member

@kyessenov I will merge this to unblock @jmillikin-stripe but can we try to figure out a way to handle this in CI? It's pretty suboptimal that this keeps happening.

@mattklein123 mattklein123 merged commit f439bb3 into envoyproxy:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants