On block interval #734
Merged
On block interval #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughAdds a new item model (Internal.item) and onBlock registration lifecycle. Refactors batching, fetch state, processing, logging, and chain management to use items (Event|Block). Introduces registration start/finish, per-chain onBlock configs, and updated source sync/options. Updates templates, tests, and dependencies accordingly. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Gen as Codegen Handlers
participant ER as EventRegister
participant Cfg as Config Builder
participant CM as ChainManager
participant CF as ChainFetcher
participant FS as FetchState
participant EP as EventProcessing
rect rgb(245,248,255)
note over Cfg,ER: Registration lifecycle (new)
Cfg->>ER: startRegistration(~ecosystem, ~multichain, ~preloadHandlers)
Gen->>ER: onBlock(options, handler)
ER-->>ER: validate & store per-chain onBlock
Cfg->>ER: finishRegistration()
ER-->>Cfg: registrations
Cfg-->>CM: config { registrations, multichain, ... }
end
rect rgb(245,255,245)
note over CM,EP: Processing with items (Event|Block)
CM->>CF: fetch next ranges
CF->>FS: handleQueryResult(...)
FS-->>CF: queue items [Event|Block]
CF-->>CM: batch of items
CM->>EP: processEventBatch(items, ...)
alt item is Block
EP-->>EP: build onBlock args {block, context}
EP-->>Gen: invoke registered onBlock handler
else item is Event
EP-->>Gen: invoke event handler (if any)
end
end
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120–180 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Poem
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
JonoPrest
reviewed
Sep 11, 2025
Comment on lines
+654
to
+657
| let rangeEnd = switch onBlockConfig.endBlock { | ||
| | Some(endBlock) => Pervasives.min(endBlock, nextLatestFullyFetchedBlockNumber) | ||
| | None => nextLatestFullyFetchedBlockNumber | ||
| } |
There was a problem hiding this comment.
Clamp this to the max queue size
This was referenced Sep 12, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit