Skip to content

Fix cli link #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix cli link #718

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07bdd84
Fix cli link
moose-code Aug 27, 2025
5e707a7
Add password is testing
moose-code Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions codegenerator/cli/templates/static/codegen/src/ink/EnvioInkApp.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,14 @@ module App = {
</Box>
<Box flexDirection={Row}>
<Text>
{"GraphQL Endpoint: "->React.string}
{"GraphQL Interface: "->React.string}
</Text>
<Text color={Info} underline=true>
{`${Env.Hasura.url}`->React.string}
</Text>
<Text color={Info}>
{" (password: testing)"->React.string}
</Text>
Comment on lines +58 to 60
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Remove hard-coded credential from TUI.

Displaying credentials is a security risk and may leak into screenshots or logs. Avoid showing secrets even in dev.

-        <Text color={Info}>
-          {" (password: testing)"->React.string}
-        </Text>

Scan for similar leaks:

🏁 Script executed:

#!/bin/bash
rg -nP -C1 '(password|secret|token)\s*:\s*(testing|test|[A-Za-z0-9._-]{6,})'

Length of output: 3762

Remove the hard-coded credential from the TUI (critical)

Our grep scan confirms that the only literal credential (" (password: testing)") is in codegenerator/cli/templates/static/codegen/src/ink/EnvioInkApp.res. All other matches are type annotations or env-var references rather than hard-coded secrets. Please remove or externalize this snippet:

--- a/codegenerator/cli/templates/static/codegen/src/ink/EnvioInkApp.res
+++ b/codegenerator/cli/templates/static/codegen/src/ink/EnvioInkApp.res
@@ lines 58-60
-        <Text color={Info}>
-          {" (password: testing)"->React.string}
-        </Text>

No other hard-coded credentials were detected by the scan. Once this is removed (and any required placeholder logic added), the critical security issue will be resolved.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<Text color={Info}>
{" (password: testing)"->React.string}
</Text>
🤖 Prompt for AI Agents 
In codegenerator/cli/templates/static/codegen/src/ink/EnvioInkApp.res around
lines 58-60 there is a hard-coded credential string " (password: testing)" that
must be removed; delete this literal from the TUI and either omit the password
display entirely or read a non-sensitive placeholder from
configuration/environment (e.g., process.env or app config) and render that
value only when present, avoiding any embedded plaintext secrets and ensuring
any display is gated by a feature flag or conditional check.

<Text color={Info} underline=true> {`${Env.Hasura.url}/v1/graphql`->React.string} </Text>
</Box>
<Messages config />
</Box>
Expand Down