Use lodash temporarily for deep cloning #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonoPrest
force-pushed
the
jp/hotfix-structured-clone
branch
from
11861f4 to
fbb9a74
Compare
|
Note I've removed it as a dep and vendored just the function we need. (Still over a thousand lines of js we could maybe ✂️ ) |
DenhamPreen
approved these changes
Mar 20, 2025
JonoPrest
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where
BigDecimalobjects had their prototypes stripped during nodejs "structuredClone".It had the
isEqualTomethod stripped away which caused a runtime failure on the inMemoryTable indexes during a test.@DZakh I've added lodash as a dep to use their
cloneDeepmethod but I think we could use rescript schema to generated deep clone functions.