Fix casting db type as nullable rather than optional #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DZakh
reviewed
Mar 13, 2025
| @as("first_event_block_number") firstEventBlockNumber: option<int>, | ||
| @as("latest_processed_block") latestProcessedBlock: option<int>, | ||
| @as("num_events_processed") numEventsProcessed: option<int>, | ||
| @as("end_block") endBlock: Js.Nullable.t<int>, |
There was a problem hiding this comment.
Shouldn't it be Js.Null.t instead?
There was a problem hiding this comment.
It could be but I didn't test, just based on the error message so I'm worried if it's possible to get undefined as well 😅
There was a problem hiding this comment.
Happy to use Js.Null.t though if I'm being silly
There was a problem hiding this comment.
I think it's fine. But I'd like to ask to leave a comment that it's probably Null and we use Nullable only because we didn't confirm it yet. So in the future we don't have hard assumptions that there's an undefined incoming
JonoPrest
commented
Mar 13, 2025
DZakh
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the bug was an indexer casting
latest_processed_blockto option type when it was nullable.It then failed the switch case on option and called the prometheus gauge function with a null value.