Fix raw events with empty params #460
Merged
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DZakh
force-pushed
the
dz/fix-raw-events-wth-empty-param
branch
from
f8195cd to
1c43813
Compare
DZakh
commented
Feb 28, 2025
Comment on lines
+286
to
+291
| let params = if params === %raw(`null`) { | ||
| // Should probably make the params field nullable | ||
| // But this is currently needed to make events | ||
| // with empty params work | ||
| %raw(`"null"`) | ||
| } else { |
There was a problem hiding this comment.
I know it's dirty, but this is what we did for fuel. Actually, with the change I moved some code from coerceToJsonPgType which made things a little bit simpler.
Ideally, all the raw_events table schema should be configured in a config and managed automatically by our db framework (which we discussed with Jono but haven't implemented)
DenhamPreen
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.