update the docker compose file to have the correct connection string for Hasura to connect to Postgres if a different user or different database are used. #459
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for Hasura to connect to Postgres if a different user or different database are used.
JasoonS
force-pushed
the
jasoons-improve-docker-compose
branch
from
d9d3728 to
a38c100
Compare
DZakh
approved these changes
Feb 24, 2025
| @@ -93,7 +93,7 @@ let deleteAllTables: unit => promise<unit> = async () => { | |||
| BEGIN | |||
| DROP SCHEMA IF EXISTS ${Env.Db.publicSchema} CASCADE; | |||
| CREATE SCHEMA ${Env.Db.publicSchema}; | |||
| GRANT ALL ON SCHEMA ${Env.Db.publicSchema} TO postgres; | |||
| GRANT ALL ON SCHEMA ${Env.Db.publicSchema} TO ${Env.Db.user}; | |||
| GRANT ALL ON SCHEMA ${Env.Db.publicSchema} TO public; | |||
There was a problem hiding this comment.
The lines existance or the change to make it a param?
I believe we do need to grant permissions to the user that HyperIndex is using. and we shouldn't hardcode it to Postgres if we are allowing it to be configurable by an environment variable.
There was a problem hiding this comment.
Ah, no worries. Actually you right - maybe not 🤔
There was a problem hiding this comment.
I think it's used for Hasura, but we can use Env.Db.user for this
|
To validate - run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.