Chore: Handle http events list #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yossi-kerner
commented
Nov 16, 2022
| Object.entries(path).forEach(([methodName, method]) => { | ||
| const httpEvent = this.functions[method.operationId]?.events?.find( | ||
| (e: ApiGatewayEvent) => e.http | ||
| (e: ApiGatewayEvent) => (e.http as any).method === methodName |
Contributor
Author
There was a problem hiding this comment.
Typescript-wise e.http could be string so TS cried but I see in the next lines we used it as an object so I did that.
eladmosh
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a lambda which have many http triggers, we generate the same
operationIdto all of them.The solution here is to add the method to the end of the
operationIdmaking it unique.