4.45.0 master <= develop #2923
4.45.0 master <= develop #2923
Conversation
issue/9097
issue/9093
�issue/9109
코코드론/entry/hardwarelite
[4.45.0] 하드웨어 PR
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
'time' is never reassigned. Use 'const' instead.
'Buffer' is not defined.
'time' is never reassigned. Use 'const' instead.
'Buffer' is not defined.
'time' is never reassigned. Use 'const' instead.
'Buffer' is not defined.
'time' is never reassigned. Use 'const' instead.
'Buffer' is not defined.
'time' is never reassigned. Use 'const' instead.
'Buffer' is not defined.
'Buffer' is not defined.
Unexpected string concatenation.
'Buffer' is not defined.
'Buffer' is not defined.
Missing radix parameter.
Missing radix parameter.
Missing radix parameter.
Missing radix parameter.
'Buffer' is not defined.
'Buffer' is not defined.
This line has a length of 114. Maximum allowed is 100.
This line has a length of 176. Maximum allowed is 100.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ··
'iconNum' is never reassigned. Use 'const' instead.
Identifier 'data_instruction' is not in camel case.
'data_instruction' is never reassigned. Use 'const' instead.
Identifier 'data_address' is not in camel case.
'data_address' is never reassigned. Use 'const' instead.
Identifier 'data_length' is not in camel case.
'data_length' is never reassigned. Use 'const' instead.
Identifier 'data_value' is not in camel case.
Identifier 'data_value' is not in camel case.
Identifier 'data_sendqueue' is not in camel case.
'data_sendqueue' is never reassigned. Use 'const' instead.
Identifier 'data_instruction' is not in camel case.
Identifier 'data_address' is not in camel case.
Identifier 'data_length' is not in camel case.
Identifier 'data_value' is not in camel case.
'packets' is never reassigned. Use 'const' instead.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ABC with abc
This line has a length of 114. Maximum allowed is 100.
This line has a length of 176. Maximum allowed is 100.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ························
'iconNum' is never reassigned. Use 'const' instead.
Identifier 'data_instruction' is not in camel case.
'data_instruction' is never reassigned. Use 'const' instead.
Identifier 'data_address' is not in camel case.
'data_address' is never reassigned. Use 'const' instead.
Identifier 'data_length' is not in camel case.
'data_length' is never reassigned. Use 'const' instead.
Identifier 'data_value' is not in camel case.
Identifier 'data_value' is not in camel case.
Identifier 'data_sendqueue' is not in camel case.
'data_sendqueue' is never reassigned. Use 'const' instead.
Identifier 'data_instruction' is not in camel case.
Identifier 'data_address' is not in camel case.
Identifier 'data_length' is not in camel case.
Identifier 'data_value' is not in camel case.
'packets' is never reassigned. Use 'const' instead.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ················
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ABC with abc
| const blockHelperLink = Entry.createElement( | ||
| 'div', | ||
| 'entryBlockHelperLinkWorkspace' | ||
| ); |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎············'div',⏎············'entryBlockHelperLinkWorkspace'⏎········ with 'div',·'entryBlockHelperLinkWorkspace'
| const blockHelperLink = Entry.createElement( | |
| 'div', | |
| 'entryBlockHelperLinkWorkspace' | |
| ); | |
| const blockHelperLink = Entry.createElement('div', 'entryBlockHelperLinkWorkspace'); |
| blockHelperLink.addClass('blockHelperLink'); | ||
| const helperLink = Entry.createElement('a', 'entryBlockHelperLink'); | ||
| helperLink.addClass('linkTextElem'); | ||
| helperLink.setAttribute('target' ,'_blank'); |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·, with ,·
| helperLink.setAttribute('target' ,'_blank'); | |
| helperLink.setAttribute('target', '_blank'); |
| i--; | ||
| } | ||
|
|
||
| if (chunk === SOME_EXPECTED_RESPONSE) { |
| const queryString = []; | ||
| const readablePorts = this.readablePorts; | ||
|
|
||
| const commandStr = Entry.hw.sendQueue['COMMAND']; |
There was a problem hiding this comment.
["COMMAND"] is better written in dot notation.
| const commandStr = Entry.hw.sendQueue['COMMAND']; | |
| const commandStr = Entry.hw.sendQueue.COMMAND; |
| for (let i = 0; i < commandStr.length; i++) { | ||
| queryString.push(commandStr.charCodeAt(i)); | ||
| } | ||
| delete Entry.hw.sendQueue['COMMAND']; |
There was a problem hiding this comment.
["COMMAND"] is better written in dot notation.
| delete Entry.hw.sendQueue['COMMAND']; | |
| delete Entry.hw.sendQueue.COMMAND; |
| const command = `up ${stick} ${time}\r`; | ||
| console.log('Constructed command:', command); | ||
|
|
||
| const commandBuffer = Buffer.from(command, 'utf8'); |
| isNotFor: ['cocodroncontrollerLite'], | ||
| func(sprite, script) { | ||
| let stick = script.getNumberValue('STICK', script) * 10; | ||
| let time = script.getNumberValue('TIME', script); |
There was a problem hiding this comment.
'time' is never reassigned. Use 'const' instead.
| let time = script.getNumberValue('TIME', script); | |
| const time = script.getNumberValue('TIME', script); |
| const command = `down ${stick} ${time}\r`; | ||
| console.log('Constructed command:', command); | ||
|
|
||
| const commandBuffer = Buffer.from(command, 'utf8'); |
| isNotFor: ['cocodroncontrollerLite'], | ||
| func(sprite, script) { | ||
| let stick = script.getNumberValue('STICK', script) * 10; | ||
| let time = script.getNumberValue('TIME', script); |
There was a problem hiding this comment.
'time' is never reassigned. Use 'const' instead.
| let time = script.getNumberValue('TIME', script); | |
| const time = script.getNumberValue('TIME', script); |
| } | ||
|
|
||
| const command = `cw ${stick} ${time}\r`; | ||
| const commandBuffer = Buffer.from(command, 'utf8'); |
No description provided.