[하드웨어] 블록메뉴, 모달팝업 UX 변경 #2805
Merged
[하드웨어] 블록메뉴, 모달팝업 UX 변경 #2805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+5330
to
5333
| var callBack = function () { | ||
| Ntry.dispatchEvent('destroyObstacle', 1, (state) => {}); | ||
| Ntry.dispatchEvent('startEnemyWalk', false, () => {}); | ||
| }; |
Contributor
Comment on lines
+5415
to
5418
| var callBack = function () { | ||
| Ntry.dispatchEvent('destroyObstacle', 1, (state) => {}); | ||
| Ntry.dispatchEvent('startEnemyWalk', false, () => {}); | ||
| }; |
Contributor
Comment on lines
+5565
to
5567
| var callBack = function () { | ||
| Ntry.dispatchEvent('startEnemyWalk', false, () => {}); | ||
| }; |
Contributor
Contributor
There was a problem hiding this comment.
Unexpected var, use let or const instead.
entryjs/src/playground/block_entry.js
Lines 5321 to 5326 in 12b380b
Contributor
There was a problem hiding this comment.
Unexpected var, use let or const instead.
entryjs/src/playground/block_entry.js
Lines 5406 to 5411 in 12b380b
Contributor
There was a problem hiding this comment.
Unexpected var, use let or const instead.
entryjs/src/playground/block_entry.js
Lines 5556 to 5560 in 12b380b
leunge
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://oss.navercorp.com/entry/entry2/issues/7700
재사용 가능성이 있는 블럭들은 주석처리 하였습니다.