Only read from the entropy-tss key-value store following a reboot
#1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameba23
changed the title
entropy-tss key-value following a reboot entropy-tss key-value store following a reboot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to, but does not completely fix #1427
In this PR, when reading a keyshare - we always read from the app state cache (memory). When modifying a keyshare, we write to both the cache and the key-value store (disk).
This will probably turn into quite a bit PR because i have made the kv store a private field on app state - to restrict where it is used. Probably this means the unsafe API needs changing to also read from cache rather than the KVDB.