Update substrate to polkadot stable2409 #1387
Conversation
pallets/parameters/src/lib.rs
Outdated
| !self.accepted_measurement_values.is_empty(), | ||
| "At least one accepted measurement value is required" | ||
| ); | ||
| // assert!(self.threshold > 0, "Threhsold too low"); |
…te-substrate-to-polkadot-stable2409
…te-substrate-to-polkadot-stable2409
| cmd.arg("--unsafe-force-node-key-generation"); | ||
| cmd.arg("--public-addr=/ip4/0.0.0.0/tcp/30333"); |
There was a problem hiding this comment.
@entropyxyz/system-reliability-engineers Ill get more information on these commands for production system and we can jam on adding it into the substrate node start process
https://github.com/entropyxyz/devops-infrastructure/issues/121
| @@ -85,12 +85,6 @@ pub mod module { | |||
| #[pallet::genesis_build] | |||
| impl<T: Config> BuildGenesisConfig for GenesisConfig<T> { | |||
| fn build(&self) { | |||
| assert!(self.threshold > 0, "Threhsold too low"); | |||
| @@ -84,6 +79,7 @@ use pallet_im_online::sr25519::AuthorityId as ImOnlineId; | |||
| use pallet_session::historical as pallet_session_historical; | |||
| #[cfg(any(feature = "std", test))] | |||
| pub use pallet_staking::StakerStatus; | |||
| #[allow(deprecated)] | |||
| @@ -547,6 +548,9 @@ parameter_types! { | |||
| pub MaximumMultiplier: Multiplier = Bounded::max_value(); | |||
| } | |||
|
|
|||
| // Can't use `FungibleAdapter` here until Treasury pallet migrates to fungibles | |||
| // <https://github.com/paritytech/polkadot-sdk/issues/226> | |||
| #[allow(deprecated)] | |||
…te-substrate-to-polkadot-stable2409
There was a problem hiding this comment.
💯 Great work, i am so thankful you did this.
I can confirm i can successfully build and run the benchmarks on this branch using the reference machine setup from https://github.com/entropyxyz/devops-infrastructure/pull/124
There are still a bunch of warnings when building with the runtime-benchmarks feature - i will make an issue, i expect they will be easy to fix.
|
|
||
| fn setup_db(key: [u8; 32]) -> Db { | ||
| EncryptedDb::open(get_db_path(true), key).unwrap() | ||
| EncryptedDb::open(get_db_path(BuildType::Test), key).unwrap() |
There was a problem hiding this comment.
As you said - weird that these were not picked up by CI before
| @@ -15,6 +15,7 @@ allow=[ | |||
| "MIT", | |||
| "MIT-0", | |||
| "MPL-2.0", | |||
| "Unicode-3.0", | |||
There was a problem hiding this comment.
Not sure if theres a procedure for who we ask when we add licenses to this list. But in this case 'unicode' looks to me like a permissive license similar to MIT so should be fine.
There was a problem hiding this comment.
ya, I mean I asked chat gpt sooo probably fine
|
|
||
| use crate::cli::Cli; | ||
|
|
||
| /// Host functions required for kitchensink runtime and Substrate node. |
Co-authored-by: peg <peg@magmacollective.org>
Left a few issues in the comments still needed to fix but this PR should be able to go in without the fixes
This updates substrate and fixes the benchmarks issues