Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONDUCTOR boundary #84

Open
wants to merge 75 commits into
base: 1.2.0rc
Choose a base branch
from
Open

Add CONDUCTOR boundary #84

wants to merge 75 commits into from

Conversation

LudwigBoess
Copy link
Collaborator

This PR adds a new boundary condition - perfect conductor.

@haykh haykh added the enhancement New feature or request label Mar 9, 2025
@haykh
Copy link
Collaborator

haykh commented Mar 13, 2025

@LudwigBoess is this ok to merge? I struggle to find time to actually implement this CONDUCTOR on other boundaries (except for -x), so perhaps we can add in later releases if there is a demand.

@LudwigBoess
Copy link
Collaborator Author

I agree that we can do the generalization later. I cleaned up the shock pgen and edited the example .toml. So I think we can merge this now.

@LudwigBoess
Copy link
Collaborator Author

I implemented a new spatial distribution: arch::Piston that sets up the shock domain only partially filled with plasma in preparation for the moving injector.
@haykh please let me know if you're fine with the naming and implementation. As an alternative I was considering arch::PartialUniform with a more general implementation of the partially filled domain.

@LudwigBoess
Copy link
Collaborator Author

I added a first attempt at a moving injector, however it doesn't work yet

@LudwigBoess
Copy link
Collaborator Author

LudwigBoess commented Mar 22, 2025

So, the injector is injecting and moving now. However, it produces weird stripes in the density and I can't pin-point where they come from exactly. It must have something to do with how I define xg_min and xg_max.

This is the initial condition:
image

This is after 116 steps:
image

You can test this with the shock.toml input file in the shock pgen folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants