Skip to content

Conversation

@Soph
Copy link
Collaborator

@Soph Soph commented Jan 19, 2026

Right now when doing entire resume soph/track-session-position then it might tell you that you need to fetch entire/sessions manually. Let's just do this automatically.

Also if we encounter an error during resume let's print the error only and not also the usage of the command which wouldn't be helpful if the error is not related to passed in params.

@Soph Soph requested a review from a team as a code owner January 19, 2026 15:50
Copilot AI review requested due to automatic review settings January 19, 2026 23:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

}

// Now resume the session with the fetched metadata
return resumeSession(metadata.SessionID, checkpointID, false)
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The force parameter should be propagated from the caller instead of being hard-coded to false. The checkRemoteMetadata function is called from resumeFromCurrentBranch which has access to the force flag. When users run resume --force, they expect to skip all confirmation prompts, but this hard-coded false would still trigger prompts during session restoration. Consider adding a force parameter to checkRemoteMetadata and passing it through to resumeSession.

Copilot uses AI. Check for mistakes.
@gtrrz-victor
Copy link
Contributor

I hit this error while trying these changes:

entire resume soph/fetch-sessions-if-needed-during-resume
Fetching session metadata from origin...
Failed to fetch metadata: failed to fetch entire/sessions from origin: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain
You can try manually: git fetch origin entire/sessions:entire/sessions

Then I found that this is a known issue with go-git: go-git/go-git#411
I added instructions to our README.md to run:

ssh-keyscan -t rsa github.com > ~/.ssh/known_hosts
ssh-keyscan -t ecdsa github.com >> ~/.ssh/known_hosts

That fixed the go-git error.

@gtrrz-victor gtrrz-victor merged commit 40b4070 into main Jan 20, 2026
3 checks passed
@gtrrz-victor gtrrz-victor deleted the soph/fetch-sessions-if-needed-during-resume branch January 20, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants