entire disable create settings.local.json or uses --project parameter #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot exist, will create one and write to it. When running entire disable without -- project parameter will write to settings.local.json, instead of settings.json when local settings does not exist. If -- project is specified, writes to settings.json - entire disable: writes to .entire/settings.local.json (creates if missing) - entire disable --project: writes to .entire/settings.json
Soph
reviewed
Jan 8, 2026
Soph
approved these changes
Jan 8, 2026
Entire-Checkpoint: 2a29469db94c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entire disable will always write to settings.local.json. If it does not exist, will create one and write to it. When running entire disable without -- project parameter will write to settings.local.json, instead of settings.json when local settings does not exist. If -- project is specified, writes to settings.json
Expected Behavior:
--project: Should always write to.entire/settings.local.json, creating it if it doesn't exist--project: Should write to.entire/settings.jsonChange 1 - setup.go: Simplified
runDisableto always write to local settings when--projectis not specified.Change 2 - setup_test.go: Commented out the old test and added
TestRunDisable_CreatesLocalSettingsWhenMissingwhich verifies:enabled: falseenabled: true)