ENT-248: Completion installation

[toothbrush]

Description

We're trying to make the onboarding as smooth as possible.

• Optimise for a user that has never seen us before - guide them through setting up PATH.
• If all goes well, call curl-bash-post-install action, which will attempt to set up shell completions

There are a lot of trade offs here and i don't know if we can achieve perfection. I couldn't think of a nice, robust way to ensure the PATH stuff, while remaining friendly and "one-shot" from the user's perspective. And between shell completions and being on PATH, clearly PATH is highest priority.

So, if the user did not have a ~/.local/bin on their PATH, we make sure that gets done. But, in the happy path case, we set up completions, too. On the bright side, if they later want to upgrade (which is just curl | bash again) we'll automatically guide them through the completions setup at that point.

I'm open to feedback on this one but it's a tough set of tradeoffs. I think this is acceptable as is, and we can circle back if not.

Trivia

Along the way i discovered:

• I would like to try and detect Fish and offer installation - separate PR
• I have a simple approach up my sleeve for allowing us to clean up completion config on uninstall – that'll also be a separate PR.
• Need to fix the issue actually reported as ENT-248 but that's easy.
• Worse: if we're telling users to curl|bash, the install script will always be running Bash. We should probably just ask users which shell they'd like to install completions for? Hmmmm... OK, it turns out $SHELL is "special". It's set to your login shell's path, and if you invoke some other shell (say you're running Zsh and execute bash) it won't be overridden. So it's an ok approach to use as we do.

---

Note

Medium Risk
Touches the installation/onboarding path and modifies how the binary is discovered on PATH, which can cause user-visible install failures or confusing behavior if edge cases are missed; changes are localized and covered by a small unit test for shell target selection.

Overview
Improves onboarding for the curl | bash installer by adding PATH guidance for first-time installs and detecting PATH conflicts, then running a new hidden CLI post-install command to optionally set up shell completions.

Moves shell completion setup out of entire enable (removes --setup-shell and related non-interactive logic) and refactors completion targeting into shellCompletionTarget() with better bash rc-file selection (.bash_profile vs .bashrc) plus tests.

Updates release packaging to generate and ship completions/* in archives, and configures Homebrew cask to install bash/zsh/fish completions.

^{Written by Cursor Bugbot for commit c269cb2. This will update automatically on new commits. Configure here.}

[Copilot]

Pull request overview

This PR moves shell-completion setup out of entire enable and into a post-install flow, aiming to improve installation ergonomics (especially for Homebrew and the curl install.sh | bash path).

Changes:

• scripts/install.sh now invokes a hidden entire curl-bash-post-install subcommand after installing the binary.
• Removed --setup-shell behavior from entire enable and refactored completion targeting logic into shellCompletionTarget().
• Release pipeline now generates and ships completions/* artifacts, and wires them into the Homebrew packaging config.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
scripts/install.sh	Runs a new post-install hook via the freshly installed entire binary.
cmd/entire/cli/setup.go	Removes enable-time completion setup; adds post-install command and refactors shell completion logic.
cmd/entire/cli/setup_test.go	Updates tests to match the changed runEnableWithStrategy signature.
cmd/entire/cli/root.go	Registers the new hidden curl-bash-post-install command.
.goreleaser.yaml	Generates completion files during release and includes them in archives/Homebrew config.

[toothbrush]

This is related to ENT-248 but isn't a fix, yet. There will be followups.

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}