Skip to content

Conversation

@khaong
Copy link
Contributor

@khaong khaong commented Feb 8, 2026

Summary

  • Renames LastInteractionAtLastInteractionTime and JSON tag last_interaction_atlast_interaction_time across all session state types and references
  • Aligns main with the field naming used in the type-consolidation branch (ENT-221), so the consolidation PR doesn't need backward compat migration for this field
  • No backward compat needed since last_interaction_at was only merged today and no state files exist with the old tag yet

Test plan

  • mise run fmt — no formatting changes
  • mise run lint — 0 issues
  • mise run test:ci — all unit + integration tests pass

🤖 Generated with Claude Code


Note

Low Risk
Primarily a field rename touching persistence tags and call sites; low logic risk but could break reading/writing existing session state files if any were created with the old JSON key.

Overview
Renames the session “last interaction” field from LastInteractionAt to LastInteractionTime across session state structs, JSON serialization (last_interaction_time), and all call sites.

Updates both auto-commit and manual-commit strategies to set/refresh LastInteractionTime on prompt submits (and when initializing new sessions), and adjusts status output and unit/integration tests to use the new field name.

Written by Cursor Bugbot for commit f382f6f. This will update automatically on new commits. Configure here.

Rename the session state field and JSON tag from last_interaction_at to
last_interaction_time for consistency with the type-consolidation branch.
Since the original field was just merged, no backward compat migration
is needed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings February 8, 2026 05:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the session state timestamp field LastInteractionAt to LastInteractionTime (and JSON tag last_interaction_atlast_interaction_time) across the CLI’s session/state persistence and strategy implementations, aligning main with the type-consolidation branch work.

Changes:

  • Renamed the field and JSON tag across session state structs and strategy state structs.
  • Updated strategy initialization/update paths to set LastInteractionTime.
  • Updated unit/integration tests and status display logic to use the new field name.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
cmd/entire/cli/strategy/session_state_test.go Updates serialization/deserialization test to use LastInteractionTime.
cmd/entire/cli/strategy/manual_commit_types.go Renames strategy SessionState field + JSON tag.
cmd/entire/cli/strategy/manual_commit_session.go Initializes new manual-commit sessions with LastInteractionTime.
cmd/entire/cli/strategy/manual_commit_hooks.go Updates existing manual-commit sessions’ interaction time on prompt submit.
cmd/entire/cli/strategy/manual_commit.go Updates conversion between session.State and strategy SessionState.
cmd/entire/cli/strategy/auto_commit.go Updates auto-commit session initialization/update to use LastInteractionTime.
cmd/entire/cli/status_test.go Updates status output tests to reference LastInteractionTime.
cmd/entire/cli/status.go Uses LastInteractionTime for “active X ago” display.
cmd/entire/cli/session/state.go Renames persisted session state field + JSON tag and updates comments.
cmd/entire/cli/integration_test/last_interaction_test.go Updates integration tests to validate LastInteractionTime behavior.

@khaong khaong marked this pull request as ready for review February 8, 2026 05:40
@khaong khaong requested a review from a team as a code owner February 8, 2026 05:40
@khaong khaong merged commit bc58b21 into main Feb 8, 2026
10 checks passed
@khaong khaong deleted the alex/rename-last-interaction-time branch February 8, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant