Skip to content

fix(test): remove t.Parallel from tests using os.Chdir #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaong merged 4 commits into from
Feb 5, 2026
Merged

fix(test): remove t.Parallel from tests using os.Chdir #146

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2cc9b1
fix(test): remove t.Parallel from tests using os.Chdir
khaong Feb 4, 2026
7805a97
Merge branch 'main' into fix/agent-test-parallel-chdir
gtrrz-victor Feb 5, 2026
9a66788
Merge branch 'main' into fix/agent-test-parallel-chdir
gtrrz-victor Feb 5, 2026
a61cb36
Merge branch 'main' into fix/agent-test-parallel-chdir
gtrrz-victor Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cmd/entire/cli/integration_test/agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ import (
)

// TestAgentDetection verifies agent detection and default behavior.
// Not parallel - contains subtests that use os.Chdir which is process-global.
func TestAgentDetection(t *testing.T) {
t.Parallel()

t.Run("defaults to claude-code when nothing configured", func(t *testing.T) {
t.Parallel()
Expand All @@ -33,7 +33,7 @@ func TestAgentDetection(t *testing.T) {
})

t.Run("claude-code detects presence when .claude exists", func(t *testing.T) {
t.Parallel()
// Not parallel - uses os.Chdir which is process-global
env := NewTestEnv(t)
env.InitRepo()

Expand Down Expand Up @@ -436,8 +436,8 @@ func TestClaudeCodeHelperMethods(t *testing.T) {
}

// TestGeminiCLIAgentDetection verifies Gemini CLI agent detection.
// Not parallel - contains subtests that use os.Chdir which is process-global.
func TestGeminiCLIAgentDetection(t *testing.T) {
t.Parallel()

t.Run("gemini agent is registered", func(t *testing.T) {
t.Parallel()
Expand All @@ -456,7 +456,7 @@ func TestGeminiCLIAgentDetection(t *testing.T) {
})

t.Run("gemini detects presence when .gemini exists", func(t *testing.T) {
t.Parallel()
// Not parallel - uses os.Chdir which is process-global
env := NewTestEnv(t)
env.InitRepo()

Expand Down