Skip to content

deletes all references about legacy strategies names#114

Merged
gtrrz-victor merged 1 commit intomainfrom
delete-old-strategies-references
Jan 29, 2026
Merged

deletes all references about legacy strategies names#114
gtrrz-victor merged 1 commit intomainfrom
delete-old-strategies-references

Conversation

@gtrrz-victor
Copy link
Contributor

@gtrrz-victor gtrrz-victor commented Jan 28, 2026

No more dual/shadow in our code.


Note

Medium Risk
Medium risk because it intentionally drops backward compatibility: existing repos with settings, commit trailers, or checkpoint metadata using dual/shadow may no longer be interpreted correctly (e.g., filtering/cleanup and strategy parsing).

Overview
Eliminates all code paths that normalize or accept legacy strategy names (dual, shadow), including config loading defaults, commit trailer parsing, checkpoint metadata reads, and the strategy registry/constants.

Updates cleanup and auto-commit orphan detection to only treat auto-commit metadata as auto-commit (no legacy alias), removes the legacy NewDualStrategy constructor, and deletes the associated tests/docs that referenced legacy names.

Written by Cursor Bugbot for commit d36bcc0. This will update automatically on new commits. Configure here.

@gtrrz-victor gtrrz-victor requested a review from a team as a code owner January 28, 2026 04:29
Copilot AI review requested due to automatic review settings January 28, 2026 04:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes all references to legacy strategy names "dual" and "shadow", which were used during initial development. The goal is to standardize on the current strategy names "auto-commit" and "manual-commit" throughout the codebase.

Changes:

  • Removed NormalizeStrategyName() function and related legacy name handling from multiple locations
  • Removed legacy strategy constants (StrategyNameDual, StrategyNameShadow) from registry
  • Removed NewDualStrategy() constructor function
  • Removed test coverage for legacy strategy name normalization
  • Updated documentation to remove references to legacy names
  • Updated test to use current function name instead of legacy

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
cmd/entire/cli/trailers/trailers.go Removed NormalizeStrategyName() function and simplified ParseStrategy() to return raw trailer value
cmd/entire/cli/strategy/registry.go Removed legacy strategy name constants and normalization helper functions
cmd/entire/cli/strategy/cleanup.go Removed legacy name filtering logic from cleanup iteration
cmd/entire/cli/strategy/auto_commit.go Removed NewDualStrategy() constructor and legacy name check in orphaned items detection
cmd/entire/cli/setup.go Removed normalization call from status display logic
cmd/entire/cli/resume_test.go Updated test to use NewAutoCommitStrategy() instead of NewDualStrategy()
cmd/entire/cli/config_test.go Removed test for legacy strategy name normalization in config loading
cmd/entire/cli/config.go Removed normalization call from settings loading
cmd/entire/cli/checkpoint/committed.go Removed normalization call from checkpoint metadata reading
CLAUDE.md Removed documentation note about legacy name support

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Soph
Soph previously approved these changes Jan 28, 2026
khaong
khaong previously approved these changes Jan 28, 2026
Copy link
Contributor

@khaong khaong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Is this the right time to introduce a changelog? This is a hard breaking change (though it only affects us)

@gtrrz-victor gtrrz-victor dismissed stale reviews from khaong and Soph via d36bcc0 January 28, 2026 22:52
@gtrrz-victor gtrrz-victor force-pushed the delete-old-strategies-references branch from 319e7fd to d36bcc0 Compare January 28, 2026 22:52
@gtrrz-victor gtrrz-victor merged commit e59934c into main Jan 29, 2026
4 checks passed
@gtrrz-victor gtrrz-victor deleted the delete-old-strategies-references branch January 29, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants