Conversation
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
===========================================
- Coverage 35.7% 23.76% -11.95%
===========================================
Files 454 458 +4
Lines 25343 25694 +351
Branches 3805 3866 +61
===========================================
- Hits 9048 6105 -2943
- Misses 15890 19281 +3391
+ Partials 405 308 -97
Continue to review full report at Codecov.
|
| Number of times to process events. Default is 1. | ||
|
|
||
| """ | ||
| yield |
There was a problem hiding this comment.
Should this be in a try-finally block? If there is an exception from within the context, we would still want to process the fired events right?
There was a problem hiding this comment.
Good point, I think a try-finally might be a good thing to do
| if not timer.IsRunning(): | ||
| # We exited the event loop on timeout | ||
| raise ConditionTimeoutError( | ||
| 'Could not destroy widget before timeout: {!r}'.format(widget)) |
There was a problem hiding this comment.
widget is not defined here. window instead?
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
- Coverage 36.63% 26.43% -10.2%
==========================================
Files 481 485 +4
Lines 26424 26757 +333
Branches 3917 3970 +53
==========================================
- Hits 9680 7074 -2606
- Misses 16321 19333 +3012
+ Partials 423 350 -73
Continue to review full report at Codecov.
|
4 participants
These are Wx versions of the GuiTestAssistant and other related code. This should not be merged until tests run cleanly. We expect significant breakage since this is running tests that would otherwise be impossible on Wx based code. They may also need work to make the tools better, safer and more cross-platform.