Refactor fields #1234
Refactor fields #1234
Conversation
| @@ -14,6 +14,8 @@ | |||
|
|
|||
| - :class:`~.CheckBoxField` | |||
| - :class:`~.ComboField` | |||
| - :class:`~.ImageField` | |||
| - :class:`~.LabelField` | |||
There was a problem hiding this comment.
Should Field and EditableField be added here?
pyface/fields/i_field.py
Outdated
| raise NotImplementedError() | ||
| def _get_control_alignment(self): | ||
| """ Toolkit specific method to get the control's read_only state. """ | ||
| raise NotImplementedError |
There was a problem hiding this comment.
Consistency nit:
| raise NotImplementedError | |
| raise NotImplementedError() |
|
|
||
|
|
||
| def alignment_to_qalignment(alignment): | ||
| return ALIGNMENT_TO_QALIGNMENT[alignment] |
There was a problem hiding this comment.
It would be good to have docstrings (or maybe just type annotations) here.
| import wx | ||
|
|
||
|
|
||
| class ImageControl(wx.Window): |
There was a problem hiding this comment.
If I wanted to see this code in action, what's the easiest way for me to exercise this code manually? Are there examples that make use of this?
There was a problem hiding this comment.
No examples currently, but this was copied and simplified from the wx TraitsUI ImageEditor's ImageControl: https://github.com/enthought/traitsui/blob/main/traitsui/wx/image_control.py
There was a problem hiding this comment.
You could exercise it with something like:
import wx
from pyface.api import ImageResource
from pyface.wx.image_control import ImageControl
window = wx.Frame()
# hack to get a wx bitmap - could also get it through wx api and an image file
bitmap = ImageResource('splash').create_bitmap()
control = ImageControl(window, bitmap)
window.Show()
I think (my wx is rusty)
Co-authored-by: Mark Dickinson <mdickinson@enthought.com>
|
This is probably going to fail because of PySide 6.5 and Numpy issues discussed in #1238 |
This is a refactor of the Field class to split it into display and editable variants: base
Fieldsmay not be editable,EditaleFieldsadd editability (ie. the value can be changed by the user). Includes tests and documentation, including fixes to make the documentation actually compile.Adds a LabelField and ImageField to demonstrate the non-editable Fields.