Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing importlib-metadata dependency #1216

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Add missing importlib-metadata dependency #1216

merged 1 commit into from
Mar 13, 2023

Conversation

mdickinson
Copy link
Member

This PR adds a missing dependency for importlib_metadata.

Strictly, we only need importlib_metadata for Python < 3.8. But using it for all Python < 3.10 allows us to use a uniform interface when dealing with entry points.

corranwebster
corranwebster approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think Pyface 8 isn't going to support Python 3.6 and we're currently not testing on 3.7 - if that helps decide which version of importlib resources you want.

@mdickinson mdickinson merged commit 85fd544 into main Mar 13, 2023
@mdickinson mdickinson deleted the add-importlib-metadata-dependency branch March 13, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corranwebster corranwebster corranwebster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdickinson @corranwebster