Fix release doc build, update changelog for 7.0.3 release. #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, this now seems to be working / failing in the expected manner. We end up executing and then failing (as expected) because |
This reverts commit 1cd2cc4.
mdickinson
commented
Apr 3, 2023
| @@ -27,7 +27,7 @@ jobs: | |||
| git worktree add ../docs gh-pages | |||
| - name: Update the docs on the gh-pages branch | |||
| run: | | |||
| python docs/update_gh_pages.py docs/build/html ../docs --tag ${{ GITHUB_REF_NAME }} | |||
| python docs/update_gh_pages.py docs/build/html ../docs --tag ${{ github.ref_name }} | |||
There was a problem hiding this comment.
This was a really dumb mistake. I think ${{ env.GITHUB_REF_NAME }} would also work here, but this seems to work in testing.
rahulporuri
approved these changes
Apr 3, 2023
mdickinson
commented
Apr 3, 2023
Supianti0115
approved these changes
Jun 23, 2024
|
@Supianti0115 Why are you reviewing something that was merged over a year ago? |
mdickinson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the automated release documentation build.