Replace namespace packages with non-namespace packages #543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current tests for the
EggPluginManager
andEggBasketPluginManager
build eggs for testing purposes. The packages that those eggs are built from are all old-stylepkg_resources
-based namespace packages. That's causing warnings, because the newest version ofsetuptools
doesn't want to support old-style namespace packages any more.This PR converts the namespace packages to normal, non-namespace packages and removes the machinery that
setuptools
is warning about (specifically, the uses ofdeclare_namespace
).I did first try to convert the old-style namespace packages to new-style PEP 420-based namespace packages, but the
EggBasketPluginManager
is not currently compatible with new-style namespace packages, and it's hard to see how it could be made compatible, given that it's based on putting eggs onsys.path
. Since we're planning to get rid of theEggBasketPluginManager
anyway, it doesn't seem worth putting in a heroic effort to make things work.Detailed changes
acme.foo
is converted to a package with distribution nameacme-foo
and import nameacme_foo
. The plugin id is left as-is.acme.bar
,acme.baz
andacme.bad
.Fixes #523