Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace namespace packages with non-namespace packages #543

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

mdickinson
Copy link
Member

Our current tests for the EggPluginManager and EggBasketPluginManager build eggs for testing purposes. The packages that those eggs are built from are all old-style pkg_resources-based namespace packages. That's causing warnings, because the newest version of setuptools doesn't want to support old-style namespace packages any more.

This PR converts the namespace packages to normal, non-namespace packages and removes the machinery that setuptools is warning about (specifically, the uses of declare_namespace).

I did first try to convert the old-style namespace packages to new-style PEP 420-based namespace packages, but the EggBasketPluginManager is not currently compatible with new-style namespace packages, and it's hard to see how it could be made compatible, given that it's based on putting eggs on sys.path. Since we're planning to get rid of the EggBasketPluginManager anyway, it doesn't seem worth putting in a heroic effort to make things work.

Detailed changes

  • The namespace package acme.foo is converted to a package with distribution name acme-foo and import name acme_foo. The plugin id is left as-is.
  • Analogous changes are applied to acme.bar, acme.baz and acme.bad.

Fixes #523

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a misleading diff - Git/GitHub has somehow decided that acme-bad/setup.py is a renamed and altered version of acme.bar/setup.py. It's actually based on acme.bad/setup.py (of course).

Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The misleading diffs make it a bit complex to see what has changed, but the end-result looks good.

@mdickinson mdickinson merged commit 518dadd into main Mar 17, 2023
@mdickinson mdickinson deleted the replace-namespace-packages branch March 17, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning for declare_namespace
2 participants