Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite fixes aimed at pytest compatibility #539

Merged
merged 8 commits into from
Mar 17, 2023
Merged

Test suite fixes aimed at pytest compatibility #539

merged 8 commits into from
Mar 17, 2023

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Mar 16, 2023

This PR:

  • Fixes the test suite so that it runs successfully under pytest. (This mainly involves changing names of objects that aren't test cases, but that pytest tries to treat as test cases out of the box.) For 3rd party packages, it's desirable that the "standard" Python tooling works.
  • Updates some test modules to use observe instead of on_trait_change and to remove some fragile module-global state into the bargain.
  • Consolidates some test classes that were shared across multiple test modules
  • Removes some places where test modules were importing from other test modules. (I'd prefer all test modules to be independent of one another; shared test machinery can go into tests.support.)
  • Uses pytest instead of unittest in the test-with-pypi GitHub Actions workflow. That means that our CI should now pick up both pytest and unittest-related issues.

Closes #537

@mdickinson
Copy link
Member Author

Fixing conflicts ...

@mdickinson mdickinson merged commit ebf8402 into main Mar 17, 2023
@mdickinson mdickinson deleted the fix-pytest branch March 17, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix test suite to work with pytest
2 participants