Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IPython #496

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Remove IPython #496

merged 4 commits into from
Mar 7, 2023

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Jan 9, 2023 •
edited
Loading

This PR removes IPython-related components from Envisage. Those components had little to do with the core domain of Envisage itself, and were proving too burdensome to maintain in the face of an ever-changing IPython ecosystem.

Closes #497

@mdickinson mdickinson marked this pull request as draft January 9, 2023 09:19
@mdickinson mdickinson changed the title Kill ipython Remove IPython Jan 9, 2023
@mdickinson mdickinson changed the title Remove IPython Example: Remove IPython Jan 9, 2023
@mdickinson mdickinson closed this Jan 9, 2023
@mdickinson mdickinson reopened this Jan 9, 2023
@mdickinson mdickinson marked this pull request as ready for review March 7, 2023 13:52
@mdickinson mdickinson changed the title Example: Remove IPython Remove IPython Mar 7, 2023
corranwebster
corranwebster approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Only references to IPython are in the changelog and a docstring emphasising that something isn't an IPython shell, so it seems to have been cleanly cut out.

@mdickinson mdickinson merged commit 02b4811 into main Mar 7, 2023
@mdickinson mdickinson deleted the kill-ipython branch March 7, 2023 14:27
@mdickinson mdickinson mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corranwebster corranwebster corranwebster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the IPython plugin
2 participants
@mdickinson @corranwebster