Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ubuntu-22.04 for wxpython run #494

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Jan 6, 2023

This PR fixes the wxPython workflow:

  • Use ubuntu-latest instead of ubuntu-20.04 (this also fixes that we were testing for ubuntu-latest when deciding whether to use xvfb-run or not)
  • Add libnotify.so.4 as a wxPython dependency
  • Use the ubuntu-22.04 wheel for wxPython

It also updates the action/cache version, in response to warnings.

Test run: https://github.com/enthought/envisage/actions/runs/3854233633

@mdickinson
Copy link
Member Author

I've piggybacked a separate change in this PR, to update the actions/cache version; we were getting warnings about deprecated functionality with the current version.

Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think that the reason that we had the older version of ubuntu was because the WxPython linux wheels were for WxPython 4.2 which we know has issues with Pyface and TraitsUI, but if it is passing with the subset used by Envisage, then we are OK.

@mdickinson mdickinson merged commit 7e1cde8 into main Jan 13, 2023
@mdickinson mdickinson deleted the fix/wxpython-workflow branch January 13, 2023 09:54
mdickinson added a commit that referenced this pull request Feb 6, 2023
This PR fixes the wxPython workflow:

- Use ubuntu-latest instead of ubuntu-20.04 (this also fixes that we
were testing for ubuntu-latest when deciding whether to use xvfb-run or
not)
- Add libnotify.so.4 as a wxPython dependency
- Use the ubuntu-22.04 wheel for wxPython

It also updates the `action/cache` version, in response to warnings.

Test run: https://github.com/enthought/envisage/actions/runs/3854233633

(cherry picked from commit 7e1cde8)
mdickinson added a commit that referenced this pull request Feb 7, 2023
This PR fixes the wxPython workflow:

- Use ubuntu-latest instead of ubuntu-20.04 (this also fixes that we
were testing for ubuntu-latest when deciding whether to use xvfb-run or
not)
- Add libnotify.so.4 as a wxPython dependency
- Use the ubuntu-22.04 wheel for wxPython

It also updates the `action/cache` version, in response to warnings.

Test run: https://github.com/enthought/envisage/actions/runs/3854233633

(cherry picked from commit 7e1cde8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants