Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin PySide6 version #487

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Pin PySide6 version #487

merged 3 commits into from
Oct 18, 2022

Conversation

mdickinson
Copy link
Member

CI is currently failing thanks to a backwards incompatible change in PySide6 6.4.0, which affects Pyface. We'll pin the PySide6 version until Pyface has a chance to adapt to the PySide6 changes.

Fixes #486.

@mdickinson
Copy link
Member Author

@rahulporuri Do you have bandwidth for review?

corranwebster
corranwebster approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@mdickinson mdickinson merged commit 5cddb45 into main Oct 18, 2022
@mdickinson mdickinson deleted the pin-pyside6 branch October 18, 2022 09:19
mdickinson added a commit that referenced this pull request Feb 6, 2023
@mdickinson
Pin PySide6 version (#487)
022d29e 
CI is currently failing thanks to a backwards incompatible change in
PySide6 6.4.0, which affects Pyface. We'll pin the PySide6 version until
Pyface has a chance to adapt to the PySide6 changes.

Fixes #486.

(cherry picked from commit 5cddb45)
This was referenced Feb 6, 2023
Merged
Closed
mdickinson added a commit that referenced this pull request Feb 7, 2023
@mdickinson
Pin PySide6 version (#487)
4deb0a5 
CI is currently failing thanks to a backwards incompatible change in
PySide6 6.4.0, which affects Pyface. We'll pin the PySide6 version until
Pyface has a chance to adapt to the PySide6 changes.

Fixes #486.

(cherry picked from commit 5cddb45)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

@corranwebster corranwebster corranwebster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI is currently broken
3 participants
@mdickinson @corranwebster @rahulporuri