Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for isinstance failure on Python 3.6 #470

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

mdickinson
Copy link
Member

This PR adds a workaround for test failures due to a bug(?) with functools.lru_cache on Python 3.6.

Closes #469

@mdickinson
Copy link
Member Author

@rahulporuri Do you have bandwidth for review?

@rahulporuri
Copy link
Contributor

@rahulporuri Do you have bandwidth for review?

yes. reviewing now.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@mdickinson mdickinson merged commit 01ace3d into main Jun 7, 2022
@mdickinson mdickinson deleted the fix/zmq-socket-test-failure-py36 branch June 7, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure in test_zmq_sockets_closed with latest packages from PyPI
2 participants