Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unregister service value error bug #345

Merged
merged 10 commits into from
Oct 27, 2020
Merged

Fix Unregister service value error bug #345

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c8c0e4c
adding a failing regression test
aaronayres35 Oct 25, 2020
dc5c552
fix failing test by adding a listener for unregistered services
aaronayres35 Oct 25, 2020
8dc8cf1
add a new test which used to pass which now fails after my attempted fix
aaronayres35 Oct 25, 2020
a3aed21
flake8
aaronayres35 Oct 25, 2020
6cca9d8
only respond to unregistered services that were originally registered…
aaronayres35 Oct 25, 2020
3785690
add setup and teardown so that neew test actually fails without added…
aaronayres35 Oct 26, 2020
4a2031e
suggested change: have plugin handle exception when attempting to unr…
aaronayres35 Oct 26, 2020
ed05f92
adding a clarifying comment
aaronayres35 Oct 26, 2020
ae4875f
flake8
aaronayres35 Oct 26, 2020
aa7e603
making suggested changes from code review
aaronayres35 Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
flake8
  • Loading branch information
@aaronayres35
aaronayres35 committed Oct 26, 2020
commit ae4875ff83e6881f727330a498d4c73790c09aad
2 changes: 1 addition & 1 deletion envisage/core_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from envisage.extension_point import ExtensionPoint
from envisage.plugin import Plugin
from envisage.service_offer import ServiceOffer
from traits.api import List, observe, on_trait_change, Str
from traits.api import List, on_trait_change, Str


class CorePlugin(Plugin):
Expand Down
2 changes: 1 addition & 1 deletion envisage/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ def unregister_services(self):
for service_id in service_ids:
# note the service may have already been individually unregistered
aaronayres35 marked this conversation as resolved.
Show resolved Hide resolved
try:
self.application.service_registry.get_service_from_id(service_id)
self.application.service_registry.get_service_from_id(service_id) # noqa: E501
aaronayres35 marked this conversation as resolved.
Show resolved Hide resolved
except ValueError:
pass
else:
Expand Down