Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create and fill plugin subpackage api modules #323

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

aaronayres35
Copy link
Contributor

fixes #306

This PR creates a new envisage.plugins.event_manager.api module and populates it with the relevant plugin class. It also adds to the existing envisage.plugins.ipython_kernel.api module to import all the classes listed in the issue 306 description. Finally, it imports from the api module in tests/examples.

…ns.ipython_kernel.api. Also import from api in tests/examples
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitchoi kitchoi merged commit bb124a4 into master Oct 21, 2020
@kitchoi kitchoi deleted the fix-306-add-new-api-modules branch October 21, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is an envisage.plugins.api useful?
3 participants